Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LT-20849: Refresh Baseline on Text switch if VScroll changes #230

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

JakeOliver28
Copy link
Contributor

@JakeOliver28 JakeOliver28 commented Dec 9, 2024

This change is Reviewable

@JakeOliver28 JakeOliver28 enabled auto-merge (squash) December 9, 2024 23:28
Copy link
Contributor

@mark-sil mark-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @JakeOliver28)


Src/LexText/Interlinear/RawTextPane.cs line 48 at r1 (raw file):

		public bool PreviousShowVScroll;

		///// <summary>

Was this commented out code an earlier idea that should be removed?

@JakeOliver28
Copy link
Contributor Author

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @JakeOliver28)

Src/LexText/Interlinear/RawTextPane.cs line 48 at r1 (raw file):

		public bool PreviousShowVScroll;

		///// <summary>

Was this commented out code an earlier idea that should be removed?

Yes, thank you. Removed the comment.

Copy link
Contributor

@mark-sil mark-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @JakeOliver28)

@JakeOliver28 JakeOliver28 merged commit 41457ef into release/9.1 Dec 10, 2024
5 checks passed
@JakeOliver28 JakeOliver28 deleted the RTLTextScrollBar branch December 10, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants